Handle multiple recurrence exclude entries on the same EXDATE line #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
- Coverage 87.84% 87.08% -0.76%
==========================================
Files 4 4
Lines 362 364 +2
Branches 93 94 +1
==========================================
- Hits 318 317 -1
- Misses 21 22 +1
- Partials 23 25 +2
Continue to review full report at Codecov.
|
mbafford
force-pushed
the
fix_multiple_exdate_same_line
branch
2 times, most recently
from
0a829bd
to
dfd65e9
Compare
mbafford
force-pushed
the
fix_multiple_exdate_same_line
branch
from
7cd93d5
to
27198ab
Compare
|
I merged #97 and incooperated this mr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My company's Exchange server ICS has
EXDATEentries in this format (multiple excludes on the same line):whereas all existing tests have
EXDATEon separate lines - e.g. fromrecurring.icstest:This adds a test for my server's format, as well as fixing the code that does not expect
component['EXDATE']to be avDDDListsobject.Moving
exceptions = {}inside the loop brings bringscest.icstest to returning 116 events, but like with #110 , that test is large - I can't easily tell what the "right" answer is (similar problem looks to have affected #110, #97, and #102).